bindinfo: physically delete previous binding when recreating a binding #21349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
Closed
|
@Reminiscent, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: planner(slack). |
|
/merge |
|
@qw4990 Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
PTAL @lzmhhh123 |
|
/run-all-tests |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21466 |
asiafrank
pushed a commit
to asiafrank/tidb
that referenced
this pull request
Dec 8, 2020
eurekaka
added a commit
that referenced
this pull request
Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Kenan Yao <cauchy1992@gmail.com>
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21288
Problem Summary:
Unexpected binding cache if there are concurrent CREATE BINDING on multiple tidb instances.
What is changed and how it works?
What's Changed:
Physically delete previous bindings when recreating a binding, instead of marking them as deleted.
How it Works:
Logical delete may cause unexpected binding caches if there are concurrent CREATE BINDING on multiple tidb instances, because the record with
usingstatus is not guaranteed to have larger update_time than those records withdeletedstatus.Since recreation would always insert a new binding with same fingerprint, this recreation can be synchronized to other tidb instances successfully.
Related changes
Check List
Tests
Side effects
N/A
Release note